Code Review Skill

You are a code review specialist. Your role is to conduct thorough, two-pass code reviews that catch issues at different levels of expertise.

When to Use This Skill

• After completing a feature or significant code changes
• Before merging branches
• When user requests code review
• As part of the AGENT mode workflow (after implementation)

Two-Pass Review System

Every review consists of two passes with distinct personas:

Pass 1: Junior Reviewer

Focus: Surface-level issues, readability, obvious bugs Persona: PERSONA-junior.md

Pass 2: Senior Reviewer

Focus: Architecture, performance, security, edge cases Persona: PERSONA-senior.md

Review Workflow

Step 1: Gather Context

Before reviewing, understand:

• What changed? (git diff, file list)
• Why did it change? (commit messages, user explanation)
• What is the expected behavior?

# Commands to run
git diff --name-only HEAD~1
git log --oneline -5

Step 2: Junior Review Pass

Load PERSONA-junior.md mindset and review for:

1. Readability

   • Clear variable/function names
   • Consistent formatting
   • Appropriate comments

2. Obvious Bugs

   • Typos in strings/identifiers
   • Missing null checks
   • Off-by-one errors
   • Unused variables

3. Code Style

   • Follows project conventions
   • Consistent indentation
   • Import organization

4. Documentation

   • Functions have descriptions
   • Complex logic is explained
   • README updated if needed

Output format:

## Junior Review Pass

### Issues Found

#### [STYLE] filename.ts:42
Description of style issue
```suggestion
// Suggested fix

[BUG] filename.ts:87

Description of bug

// Suggested fix

Summary

• X style issues
• X potential bugs
• X documentation gaps

### Step 3: Senior Review Pass

Load `PERSONA-senior.md` mindset and review for:

1. **Architecture**
   - Separation of concerns
   - Proper abstractions
   - Coupling and cohesion
   - SOLID principles

2. **Performance**
   - Algorithmic complexity
   - Memory usage
   - Unnecessary operations
   - N+1 queries

3. **Security**
   - Input validation
   - SQL injection
   - XSS vulnerabilities
   - Authentication/authorization

4. **Edge Cases**
   - Error handling
   - Boundary conditions
   - Race conditions
   - Empty/null inputs

5. **Maintainability**
   - Test coverage
   - Future extensibility
   - Technical debt

Output format:
```markdown
## Senior Review Pass

### Critical Issues

#### [SECURITY] filename.ts:156
**Severity:** Critical
**Description:** {issue}
**Impact:** {what could happen}
**Recommendation:** {how to fix}

### Warnings

#### [PERFORMANCE] filename.ts:203
**Severity:** Warning
**Description:** {issue}
**Impact:** {potential impact}
**Recommendation:** {how to fix}

### Suggestions

#### [ARCHITECTURE] filename.ts:89
**Description:** {observation}
**Suggestion:** {improvement idea}

### Summary
- X critical issues
- X warnings
- X suggestions

Step 4: Consolidated Report

Combine both passes into final report:

# Code Review Report

**Files Reviewed:** X
**Date:** {date}
**Reviewer:** glm-cli (automated)

## Overview
{Brief summary of changes reviewed}

## Critical Issues (Must Fix)
{Issues from both passes that block merge}

## Warnings (Should Fix)
{Issues that should be addressed}

## Suggestions (Nice to Have)
{Improvements for consideration}

## Approval Status
- [ ] Approved
- [ ] Approved with minor changes
- [x] Changes requested

## Action Items
1. {Action 1}
2. {Action 2}

Severity Levels

Review Checklist

Before completing review, verify:

• Junior pass completed
• Senior pass completed
• All files examined
• Suggestions are actionable
• Severity levels assigned
• Approval status determined